[Driver][SYCL] Improve diagnostics when linking with mismatched objects #6591
+181
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing linking with -fsycl, it is required that the user provide the -fsycl-targets=triple option so the driver knows which targets to unbundle and use. There is no indication to the end user if they are using a command line that matches up with the generated objects and archives. Perform some additional checking against the archives and objects as they are provided on the command line and cross check with what the user has specified for targets. If these do not match, emit a diagnostic stating as such and also list out the targets that were found in the objects.
elizabethandrews
approved these changes
Aug 17, 2022
Contributor
elizabethandrews
left a comment
elizabethandrews
left a comment
There was a problem hiding this comment.
FE changes LGTM!
smanna12
approved these changes
Aug 18, 2022
Contributor
Author
|
Failures do not look related to my change (which is diagnostic in nature only) |
Contributor
Author
|
@hchilama, can you take a look? |
hchilama
approved these changes
Aug 18, 2022
Contributor
Author
|
@intel/llvm-gatekeepers, this should be ready to go. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing linking with -fsycl, it is required that the user provide
the -fsycl-targets=triple option so the driver knows which targets to
unbundle and use. There is no indication to the end user if they are using
a command line that matches up with the generated objects and archives.
Perform some additional checking against the archives and objects as they
are provided on the command line and cross check with what the user has
specified for targets. If these do not match, emit a diagnostic stating
as such and also list out the targets that were found in the objects.