Skip to content

[SYCL][ABI-Break] Make sycl::exception has_context noexcept #6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[SYCL][ABI-Break] Make sycl::exception has_context noexcept #6597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ set(SYCL_MINOR_VERSION 7)
set(SYCL_PATCH_VERSION 0)
# Don't forget to re-enable sycl_symbols_windows.dump once we leave ABI-breaking
# window!
set(SYCL_DEV_ABI_VERSION 9)
set(SYCL_DEV_ABI_VERSION 10)
if (SYCL_ADD_DEV_VERSION_POSTFIX)
set(SYCL_VERSION_POSTFIX "-${SYCL_DEV_ABI_VERSION}")
endif()
Expand Down
2 changes: 1 addition & 1 deletion sycl/include/sycl/exception.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class __SYCL_EXPORT exception : public std::exception {

const char *what() const noexcept final;

bool has_context() const;
bool has_context() const noexcept;

context get_context() const;

Expand Down
2 changes: 1 addition & 1 deletion sycl/source/exception.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const std::error_category &exception::category() const noexcept {

const char *exception::what() const noexcept { return MMsg->c_str(); }

bool exception::has_context() const { return (MContext != nullptr); }
bool exception::has_context() const noexcept { return (MContext != nullptr); }

context exception::get_context() const {
if (!has_context())
Expand Down