[SYCL] Fix cleanup of deferred commands #6605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we work in multiple threads and lock on graph failed because of its ownership by another thread - we add command to cleanup to the pool with deferred commands. Sometimes it happens that this pool is never cleaned and even in scheduler destructor it is ignored because of not fully correct check. Current solution let scheduler to cleanup deferred commands in its destructor. Although in most cases it will be cleaned up much earlier because in any place where vector ToCleanup was empty - we will check if there is deferred commands awaiting for destruction. Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
sergey-semenov
approved these changes
Aug 23, 2022
KseniyaTikhomirova
changed the title
KseniyaTikhomirova
changed the title
Contributor
Author
|
intel/llvm-test-suite#1173 - disabling of flaky failing tests on HIP |
Contributor
Author
|
@intel/llvm-gatekeepers, hello, could you please merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we work in multiple threads and lock on graph failed because of its ownership by another thread - we add command to cleanup to the pool with deferred commands. Sometimes it happens that this pool is never cleaned and even in scheduler destructor it is ignored because of not fully correct check.
Current solution let scheduler to cleanup deferred commands in its destructor. Although in most cases it will be cleaned up much earlier because in any place where vector ToCleanup was empty - we will check if there is deferred commands awaiting for destruction.
Signed-off-by: Tikhomirova, Kseniya kseniya.tikhomirova@intel.com