[SYCL] Remove and deprecate address spaces #6606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DPC++ has a selection of extension address spaces with deprecated namings. This commit removes these old namings for the address spaces. Additionally, this PR adds a deprecation warning for sycl::access::address_space::constant_space as it is deprecated in SYCL2020. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Contributor
Author
|
/verify with intel/llvm-test-suite#1163 |
aelovikov-intel
approved these changes
Aug 18, 2022
| 2, | ||
| local_space = 3, | ||
| ext_intel_global_device_space = 4, | ||
| ext_intel_global_host_space = 5, |
Contributor
There was a problem hiding this comment.
Is it in any way related to the host-device that was removed in SYCL2020 ? If so, should we put a deprecation here as well?
Contributor
Author
There was a problem hiding this comment.
Seems like it maps to opencl_global_host according to the design document, so I don't think it has any relation to the host device.
Contributor
Author
|
/verify with intel/llvm-test-suite#1163 |
1 similar comment
Contributor
Author
|
/verify with intel/llvm-test-suite#1163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPC++ has a selection of extension address spaces with deprecated namings. This commit removes these old namings for the address spaces. Additionally, this PR adds a deprecation warning for sycl::access::address_space::constant_space as it is deprecated in SYCL2020.