[SYCL][NFC] Remove unnecessary NULL check for 'Fn' #6726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klocwork thinks that it is possible for 'Fn' to be a nullptr due to this check but there's already an assert at the beginning of CodeGenFunction::GenerateCode to avoid that possibility. https://reviews.llvm.org/D115817
premanandrao
reviewed
Sep 7, 2022
Contributor
premanandrao
left a comment
premanandrao
left a comment
There was a problem hiding this comment.
I would mark the change with [NFC] in the title.
Is the reference to the community change to show which changeset the assert was added in? I found it confusing and would suggest removing it.
Code change itself looks good.
schittir
changed the title
Contributor
Author
Done. |
Fznamznon
approved these changes
Sep 8, 2022
elizabethandrews
approved these changes
Sep 8, 2022
premanandrao
approved these changes
Sep 8, 2022
smanna12
approved these changes
Sep 8, 2022
schittir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Klocwork thinks that it is possible for 'Fn' to be a nullptr due to this
check but there's already an assert at the beginning of
CodeGenFunction::GenerateCode to avoid that possibility.