Skip to content

Conversation

@steffenlarsen
Copy link
Contributor

According to the SYCL 2020 specification, CL/sycl.hpp should supply the cl prefix namespace for backwards compatibility, but it does not specify that the namespace is deprecated. This commit removes the deprecation message.

According to the SYCL 2020 specification, CL/sycl.hpp should supply
the cl prefix namespace for backwards compatibility, but it does not
specify that the namespace is deprecated. This commit removes the
deprecation message.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from a team as a code owner September 8, 2022 16:03
@jbrodman jbrodman self-requested a review September 8, 2022 16:05
Copy link
Contributor

@jbrodman jbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the spec didn't actually deprecate it... Also, I think all the actually "deprecated" things are left for some time for "compatibility" reasons and allowing the user to update the codebase.

How is this namespace so different that the spec doesn't intend to remove it?

@steffenlarsen
Copy link
Contributor Author

I wonder why the spec didn't actually deprecate it... Also, I think all the actually "deprecated" things are left for some time for "compatibility" reasons and allowing the user to update the codebase.

How is this namespace so different that the spec doesn't intend to remove it?

I am not certain what the intention was in not deprecating it, but until the spec says that it is deprecated we should not deprecate it. Many things were removed from 1.2.1 that were not deprecated before removal, so similar to how we treat those while implementing SYCL 2020, if the next version of SYCL removes the backwards-compatibility header and namespace we can deprecate it then.

@steffenlarsen steffenlarsen merged commit 85b415c into intel:sycl Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants