[SYCL] Bump SYCL_MINOR_VERSION #6855
Conversation
Unlike previous releases we change the policy of bumping the version to be done at the beginning of the development cycle instead of its end. That allows customers who are using development snapshots to guard their code in a way that would keep working after the actual release is done.
This reverts commit 6b921f5.
sycl/CMakeLists.txt
Outdated
| # The change in SYCL_MAJOR_VERSION must be accompanied with the same update in | ||
| # llvm/clang/lib/Driver/CMakeLists.txt. | ||
| # | ||
| # For the current development cycles MINOR has been bumped up and MAJOR wasn't. |
There was a problem hiding this comment.
Suggest removing this line as it can be misleading if anybody forgets to update it.
There was a problem hiding this comment.
Well, I think we have the information to know what has been changed during the current cycle:
MINOR == 0 ==> MAJOR has been incremented
MINOR != 0 ==> It has been increased as part of previous release before this cycle started.
so, technically, we can remove it. I'm not sure if we want though.
@ intel/llvm-reviewers-runtime, what do others think?
There was a problem hiding this comment.
I've had an offline chat with @steffenlarsen (based on the doc counterpart PR) and he asked essentially the same from a slightly different angle. I'll make the change.
|
Can we proceed with this? @intel/llvm-reviewers-runtime , ping. |
|
@intel/llvm-gatekeepers , this PR is ready. |
3 participants
Unlike previous releases we change the policy of bumping the version to be done at the beginning of the development cycle instead of its end. That allows customers who are using development snapshots to guard their code in a way that would keep working after the actual release is done.
The documentation for this is being done as #6856
We have consensus on how/when MAJOR/MINOR have to be bumped, so do it now. There are some debates regarding PATCH/DEV versions updates so the documentation would be updated later.