Skip to content

[ESIMD] Fix DPAS implementations accepting/returning fp16/bf16 #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2022
Merged

[ESIMD] Fix DPAS implementations accepting/returning fp16/bf16 #6891

merged 4 commits into from
Sep 29, 2022

Conversation

@v-klochkov
Copy link
Contributor

@v-klochkov v-klochkov commented Sep 28, 2022

Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com

@v-klochkov
[ESIMD] Fix DPAS implementations accepting/returning fp16/bf16
d5ed275 
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov v-klochkov marked this pull request as ready for review September 28, 2022 03:59
@v-klochkov v-klochkov requested a review from a team as a code owner September 28, 2022 03:59
@v-klochkov v-klochkov mentioned this pull request Sep 28, 2022
Merged
@v-klochkov v-klochkov requested a review from kbobrovs September 28, 2022 04:37
@v-klochkov
[NFC] Replace usage of deprecated/upper-case enums from dpas_argument…
71a76e2 
…_type with lower-case variants

Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
kbobrovs
kbobrovs reviewed Sep 28, 2022
View reviewed changes
@v-klochkov
Copy link
Contributor Author

v-klochkov commented Sep 29, 2022

The fail on Jenkins/Precommit (RHEL build error) is unrelated to this PR.
Exactly same error is shown for other PRs being tested, for example:
#6908 - http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FBuild_PR_RHEL/detail/Build_PR_RHEL/16488/pipeline
or #6905 - http://llvm-ci-test2.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FBuild_PR_RHEL/detail/Build_PR_RHEL/2757/pipeline

Error there is same:

[2022-09-29T02:19:12.304Z] /netbatch/donb3665228_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Build_PR_RHEL/llvm.src/sycl/plugins/opencl/pi_opencl.hpp:38:21: error: class ‘OCLV::OpenCLVersion’ does not have any field named ‘gnu_dev_major’

[2022-09-29T02:19:12.304Z]    OpenCLVersion() : major(0), minor(0) {}

[2022-09-29T02:19:12.304Z]                      ^

[2022-09-29T02:19:12.304Z] /netbatch/donb3665228_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Build_PR_RHEL/llvm.src/sycl/plugins/opencl/pi_opencl.hpp:38:31: error: class ‘OCLV::OpenCLVersion’ does not have any field named ‘gnu_dev_minor’

[2022-09-29T02:19:12.304Z]    OpenCLVersion() : major(0), minor(0) {}

@pvchupin
Copy link
Contributor

pvchupin commented Sep 29, 2022

The fail on Jenkins/Precommit (RHEL build error) is unrelated to this PR. Exactly same error is shown for other PRs being tested, for example: #6908 - http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FBuild_PR_RHEL/detail/Build_PR_RHEL/16488/pipeline or #6905 - http://llvm-ci-test2.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FBuild_PR_RHEL/detail/Build_PR_RHEL/2757/pipeline

Error there is same:

[2022-09-29T02:19:12.304Z] /netbatch/donb3665228_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Build_PR_RHEL/llvm.src/sycl/plugins/opencl/pi_opencl.hpp:38:21: error: class ‘OCLV::OpenCLVersion’ does not have any field named ‘gnu_dev_major’

[2022-09-29T02:19:12.304Z]    OpenCLVersion() : major(0), minor(0) {}

[2022-09-29T02:19:12.304Z]                      ^

[2022-09-29T02:19:12.304Z] /netbatch/donb3665228_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Build_PR_RHEL/llvm.src/sycl/plugins/opencl/pi_opencl.hpp:38:31: error: class ‘OCLV::OpenCLVersion’ does not have any field named ‘gnu_dev_minor’

[2022-09-29T02:19:12.304Z]    OpenCLVersion() : major(0), minor(0) {}

Jenkins issue fixed at #6906

@pvchupin pvchupin merged commit 8f0960e into intel:sycl Sep 29, 2022
@v-klochkov v-klochkov deleted the dpas_new_low_level_api branch September 29, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kbobrovs kbobrovs kbobrovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-klochkov @pvchupin @kbobrovs