Skip to content

[SYCL] Deprecate SYCL_DEVICE_FILTER environment variable #7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2022
Merged

[SYCL] Deprecate SYCL_DEVICE_FILTER environment variable #7207

merged 5 commits into from
Nov 1, 2022

Conversation

@raaiq1
Copy link
Contributor

@raaiq1 raaiq1 commented Oct 27, 2022

  • This patch prints an error warning when the environment variable SYCL_DEVICE_FILTER is set.
  • In-tree tests now use ONEAPI_DEVICE_SELECTOR instead of SYCL_DEVICE_FILTER.
  • The function SYCLConfig<SYCL_DEVICE_FILTER> which retrieves the value of the deprecated environment variable is also deprecated.
  • A switch is added to pi::findPlugins() to use ONEAPI_DEVICE_SELECTOR if possible

@raaiq1
[SYCL] Deprecate SYCL_DEVICE_FILTER environment variable
95a0402 
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
@raaiq1 raaiq1 requested a review from a team as a code owner October 27, 2022 17:43
@raaiq1 raaiq1 requested a review from romanovvlad October 27, 2022 17:43
@raaiq1 raaiq1 mentioned this pull request Oct 28, 2022
Merged
raaiq1 added 2 commits October 31, 2022 07:19
@raaiq1
Fixed more failing unittests
87429d5 
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
@raaiq1
Small fix
8dad15b 
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
@raaiq1
Copy link
Contributor Author

raaiq1 commented Oct 31, 2022

Slight ping to @romanovvlad to review PR

@raaiq1
Fix documentation
9787d78 
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
@raaiq1 raaiq1 requested a review from a team as a code owner October 31, 2022 16:55
bader
bader reviewed Nov 1, 2022
View reviewed changes
@raaiq1 @bader
Update sycl/doc/EnvironmentVariables.md
c5a3ec3 
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
@againull againull merged commit 77b6f34 into intel:sycl Nov 1, 2022
@raaiq1 raaiq1 deleted the deprecate_sycl_filter branch November 4, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bader bader bader approved these changes

@romanovvlad romanovvlad romanovvlad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raaiq1 @bader @romanovvlad @againull