Skip to content

Conversation

@sommerlukas
Copy link
Contributor

Remove includes of LLVM headers from the public surface of the JIT compiler (i.e., public headers).

This avoids inheriting warnings from the LLVM codebase, which turn into compilation errors when compiling the SYCL runtime with SYCL_ENABLE_WERROR=ON.

Signed-off-by: Lukas Sommer lukas.sommer@codeplay.com

Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
@sommerlukas
Copy link
Contributor Author

See the discussion here for more background on the issue when compiling with SYCL_ENABLE_WERROR=ON.

@sommerlukas
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1416

@sommerlukas sommerlukas requested a review from bader January 16, 2023 09:36
@sommerlukas sommerlukas temporarily deployed to aws January 16, 2023 09:58 — with GitHub Actions Inactive
Copy link
Contributor

@Naghasan Naghasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sommerlukas sommerlukas temporarily deployed to aws January 16, 2023 16:04 — with GitHub Actions Inactive
@bader bader merged commit ded5db5 into intel:sycl Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants