This repository was archived by the owner on Aug 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
DG2 supports for XeTLA SDP example #159
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airMeng
reviewed
Mar 8, 2024
examples/08_scaled_dot_product_attention/scaled_dot_product_attention.cpp
Outdated
Show resolved
Hide resolved
examples/08_scaled_dot_product_attention/scaled_dot_product_attention.cpp
Outdated
Show resolved
Hide resolved
luoyu-intel
reviewed
Mar 11, 2024
examples/08_scaled_dot_product_attention/scaled_dot_product_attention.cpp
Show resolved
Hide resolved
Contributor
Author
|
Just force-pushed to avoid reorganizing the kernel function of example 08. |
sunjiweiswift
approved these changes
Mar 13, 2024
airMeng
approved these changes
Mar 14, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change: feature
Description
DG2 supports for XeTLA SDP example and some more improvements:
gpu_archdata_type_a_t<dict>==>typename dict::template find_elem_t<tune_key::data_type_a>::type) (include/kernel/default_config/common.hpp)param_optimizer_modewhich could have value ofparam_optimizer_mode::keep_shape(default toparam_optimizer_mode::full) to preventdecision_tree_optimizerchanging tile sizes (include/kernel/default_config/common.hpp)selector_tfrom deriving to type aliasing so it won't be a barrier when debuging withXETLA_PRINT<xxx_selector_t<...>>()gpu_archon current machine (probably not compatible with AOT)How has this PR been tested?
Compilation on linux-2024.0, linux-2024.1 and win-2024.0
cmake -GNinja .. && ninjaExamples on Arc and PVC (with no error):
Unit tests on PVC:
Dependency Change?
No