[MLIR][ODS] Fully qualify namespace for mlir::Attribute in ODS generated code (cherry-pick from upstream) #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted code (#168536) ODS generate code can be included and used outside of the `mlir` namespace and so references to symbols in the mlir namespace must be fully qualified.
BogdanDragosV
changed the title
BogdanDragosV
changed the title
hrotuna
approved these changes
Nov 21, 2025
natanael-cintean
approved these changes
Nov 21, 2025
Natan-GabrielTiutiuIntel
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ODS generate code can be included and used outside of the
mlirnamespace and so references to symbols in the mlir namespace
must be fully qualified.
JIRA ticket
EISW-190450
[Core] Remove SmallVectorU8Prop and temporary optional property from core dialect
Related PR in NPU Compiler and/or OpenVINO repository with sub-module update
(llvm/llvm-project#168536)
Other related tickets