fix standalone dq conversion #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhkale17
requested review from
ankitm3k,
preetha-intel,
sfatimar and
vthaniel
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the retention of Dequantize layer if it feeds as an input to the 'Add' (supported) operator.
Motivation and Context
The stand alone dequantize layer after gather op was striped out and replaced by the Identity node.
The stand alone dequantize layer is having input as uint8 and output as float32 and this float32 output is input to the Add op.
Add op expects both inputs to be of same data type. When Identity op is inserted in place of dequantize layer the data type conversion has issues due to which the model PSQ1 is not functional.
By retaining the Dequantize layer, we ensure proper data type conversion, allowing both inputs to the Add operator to be float32 and thus resolving the issue.
Open issues fixed with the PR:
https://jira.devtools.intel.com/browse/EISW-128302
https://jira.devtools.intel.com/browse/EISW-127924