Fix to resolve EPCtx filename confusion with wrapped OVIRs #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ORT_THROW can take more than one argument, however, the code style does seem to be one error string per ORT THROW, so we can accept this update. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MayureshV1
approved these changes
Aug 25, 2025
MayureshV1
left a comment
MayureshV1
left a comment
There was a problem hiding this comment.
Tested this with native ONNX and OVIR wrapped ONNX models and was able to generate EPCTX model.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a filename confusion issue when reading EPCtx wrapped OpenVINO IR models by adding proper path checking logic. The change ensures that the correct file path is used when accessing cached EPCtx models.
- Adds conditional logic to determine the correct file path for EPCtx wrapped OVIR models
- Improves error messaging for failed file operations during model export
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vthaniel
pushed a commit
that referenced
this pull request
Aug 28, 2025
* Fix to resolve EPCtx filename confusion with wrapped OVIRs * Update onnxruntime/core/providers/openvino/backend_manager.cc ORT_THROW can take more than one argument, however, the code style does seem to be one error string per ORT THROW, so we can accept this update. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a gate for checking the file path of EPCtx wrapped OV IRs to ensure the correct file is read.
Motivation and Context
This resolves EPCtx wrapped OV IR model caching for the case where the path to the cached file is explicitly set.