Skip to content

Conversation

@azabazno
Copy link
Contributor

@azabazno azabazno commented Dec 7, 2020

No description provided.

@fzou1 fzou1 requested review from cdai2, haonanya and wenju-he December 7, 2020 13:26
cdai2
cdai2 previously approved these changes Dec 7, 2020
Copy link
Contributor

@cdai2 cdai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to spec, t好is attribute "Requires support for OpenCL C 2.0 or newer"
so according to my understanding, it should be "if (S.LangOpts.OpenCLVersion < 200)". right?

@cdai2 cdai2 dismissed their stale review December 7, 2020 14:21

re-review

@azabazno
Copy link
Contributor Author

azabazno commented Dec 7, 2020

Oh, yeah. Thanks, will fix in nearest time

@azabazno azabazno requested a review from cdai2 December 7, 2020 14:39
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzou1 fzou1 merged commit 33cb76d into intel:ocl-open-80 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants