This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fix and Enable Clang compilation #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accessAsInteger function prototype is defined in BaseParameter abstract class with an uint32_t type. Nevertheless in BitParameter the overloaded function take an uin64_t. It seems that GCC accepts wrongly this mistake but clang don't. This patch corrects the function prototype accordingly to the one defined in BaseParameter. It allows the project to be compiled with clang. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Swig does not any more generates code which require this flag. Moreover this flag is not present in clang compiler. Change-Id: I386ab576e93003d69dcf2c593670245070770024 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Contributor
|
travis compilation is fixed in #94 (just some comments which need to be fixed) |
Contributor
There was a problem hiding this comment.
Maybe add -Wno-error and add a comment explaining that the code is generated by swig and thus can not be fixed even if warned.
Contributor
|
Uncomment # clang in .travis.yml:12 |
Contributor
|
All these commits have been merged in #133. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.