This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fix ILogger::operator<< when called on list<string> #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Build breaks because the skeleton plugin is not explicitly compiled with C++11 and ILogger.h now requires it. |
dawagner
force-pushed
the
fix-log-on-list
branch
2 times, most recently
from
9efe1b6 to
fe3a46c
Compare
Since the core is moving to C++11, some headers will at some point contain C++11-only features which will make it necessary to switch plugins to C++11 as well. Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
There was a problem hiding this comment.
Are you sure this empty test is still useful ? A stream string is only created if there is things to put in.
Contributor
There was a problem hiding this comment.
maybe we could add std::to_string instead of an ostringstream ?
mLogs.back += std::to_string(log);... Never mind, std::to_string(std::string) (<=> id) does not exist. Unfortunately.
You could add a private overload in your file though.
std::string to_string(const std::string &str) { return str; }
...
using std::to_string
mLogs.back += to_string(log);
...
std::list<std::string> mLogs;Calling info() << someList should be identical to calling info() << element on each element of someList. This was not the case because when used on a list, the string was concatenated with \n and the logging callback called once. Instead, the logging callback is now called for each line. Fixes intel#125. Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
|
👍 |
dawagner
added a commit
that referenced
this pull request
Jun 4, 2015
Fix ILogger::operator<< when called on list<string> Calling info() << someList should be identical to calling info() << element on each element of someList. This was not the case because when used on a list, the string was concatenated with \n and the logging callback called once. Instead, the logging callback is now called for each line. Fixes #125.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling info() << someList should be identical to calling info() << element on
each element of someList.
This was not the case because when used on a list, the string was concatenated
with \n and the logging callback called once. Instead, the logging callback
is now called for each line.
Fixes #125.
Signed-off-by: David Wagner david.wagner@intel.com