This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Android: Make libxmserializer dynamic #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krocard
force-pushed
the
remove_include_library_trick
branch
from
6f364e0 to
ee608b8
Compare
Contributor
Author
Contributor
|
👍 |
Contributor
|
Same commit message comment. Please check that it is compiling on a android nexus lunch target (or - easier - for the arm emulator): I've noted differences between arm and x86 linking phase in the past. |
The Paramter Framework has recently removed its *_include libraries (this trick was not working on osx). They were used to include headers without linking against the libraries in the android build system. There are two ways to include library headers: - copy the headers (but that would be in contradiction with how the main pfw headers are included) - link against the library (chosen solution) In order for the plugins to avoid linking against a static libxmlserializer - ie add it and it's dependency to all plugins - the xmlserializer library is now dynamic. Change-Id: I79feb434c7b44ad4473d62276efc3c4b77928894
krocard
force-pushed
the
remove_include_library_trick
branch
from
ee608b8 to
9e69aed
Compare
krocard
added a commit
that referenced
this pull request
Jun 10, 2015
Android: Make libxmserializer dynamic The Parameter Framework has recently removed (this trick was not working on osx) its *_include libraries that were used to include headers without linking against the libraries in the android build system. There are two ways to include library headers: - copy the headers (but that would be in contradiction with how the main pfw headers are included) - link against the library (chosen solution) In order for the plugins to avoid linking against a static libxmlserializer - ie add it and its dependency to all plugins - the xmlserializer library is now dynamic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Parameter Framework has recently removed (this trick was not working on osx) its *_include libraries that were used to include headers without linking against the libraries in the android build system.
There are two ways to include library headers:
In order for the plugins to avoid linking against a static
libxmlserializer - ie add it and its dependency to all plugins -
the xmlserializer library is now dynamic.
The alsa and filesystem plugins are also updated.