This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Improve build experience #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
Contributor
There was a problem hiding this comment.
Why so ? I have never used absolute patch for CMake options ?
Contributor
Author
There was a problem hiding this comment.
Seen with you: it is necessary - at least on Windows. I can add an explanation if you like: "You don't know where relative paths will be evaluated from".
EDIT: 👍 done
Contributor
There was a problem hiding this comment.
Never mind, keep it like this. 👍
- Do not turn BASH_COMPLETION buid option on by default on Windows; - Fix a typo in an option documentation; - List known dependencies in the README; - Give some pointers on how to easily compile on Windows; - Print an error if SWIG isn't found when Python bindings are to be compiled. Signed-off-by: David Wagner <david.wagner@intel.com>
On multi-configuration build systems (such as Visual Studio or NMake), the build type (aka configuration) is decided at build time whereas on single-configuration build systems, it is set at configuration time (obviously). Remove the unnecessary `-DCMAKE_BUILD_TYPE` option from CMake invocation. Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
force-pushed
the
improve-build-experience
branch
from
c6839a7 to
6475e78
Compare
We used to add the libxml2 directory to the PATH when building although we only intended to do so for the purpose of the tests. It led CMake to find libxml2 for the wrong reasons. It actually shouldn't have been able to find it since libxml2's dir wasn't added to the CMAKE_PREFIX_PATH. The directory where libxml2 has been extracted is now added to the prefix path and its 'bin' subdirectory also added to a variable only used during the tests. Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
|
|
dawagner
force-pushed
the
improve-build-experience
branch
from
6475e78 to
e0a71cf
Compare
Use `cmake -L` and optionaly filter-out `^CMAKE_`. This is done by hiding cache entries that are not one of those. Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
Author
|
I made a small change to the last commit, on which we orally agreed upon. |
dawagner
added a commit
that referenced
this pull request
Oct 20, 2015
Improve build experience Add some doc, make it easy to list available configuration options and clean appveyor.yml up a bit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krocard @tcahuzax Please review
EDIT: 👍 done