This repository was archived by the owner on Aug 5, 2022. It is now read-only.
xml-generator: be compatible with both python2.7 and 3.x #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xml-generator scripts were using deprecated Python 2 constructs and were
unable to run with Python 3.x. This is an issue on Windows because CMake seems
to use the highest version available even when there is a version closer to
what was requested. If both 2.7 and 3.x are installed on the system,
find_package(PythonInterp 2.7 EXACT REQUIRED)
may fail and
find_package(PythonInterp 2.7 REQUIRED)
may find 3.x.
This is a known issue for some time now:
https://public.kitware.com/Bug/view.php?id=15661
Signed-off-by: David Wagner <david.wagner@intel.com>
Current coverage is
|
Contributor
|
👍 |
Contributor
Author
|
@krocard Please review. |
Contributor
|
👍 |
krocard
added a commit
that referenced
this pull request
Mar 8, 2016
xml-generator: be compatible with both python2.7 and 3.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xml-generator scripts were using deprecated Python 2 constructs and were
unable to run with Python 3.x. This is an issue on Windows because CMake seems
to use the highest version available even when there is a version closer to
what was requested. If both 2.7 and 3.x are installed on the system,
may fail and
may find 3.x.
This is a known issue for some time now:
80.30%@@ master #358 diff @@ ===================================== Files 211 211 Stmts 7184 7184 Branches 0 0 Methods 0 0 ===================================== Hit 5769 5769 Partial 0 0 Missed 1415 1415