This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Dead code removal and some factorization #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CBitParameterType::isEncodable private method wasn't used and as such was dead code. Signed-off-by: David Wagner <david.wagner@intel.com>
Current coverage is
|
| std::string asString(const std::list<std::string> &lstr, const std::string &separator = "\n"); | ||
| template <class Sequence> | ||
| std::string asString(const Sequence &lstr, const std::string &separator = "\n") | ||
| { |
Contributor
There was a problem hiding this comment.
static_assert(std::equal<lstr::element_type, std::string>::value, "Provided output containor container can not contain string.")
It was only explicitly implemented for std::list. Making it template over any string sequence (that have a begin() and an end() methods) allows removing some hand-coded loop in RequestMessage.cpp. Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
force-pushed
the
dead-code-and-factorization
branch
from
beccb14 to
ea46088
Compare
Having a function return a const value (i.e. not a reference nor a pointer) was already rarely useful in C++03 but is now rather suspicious in C++11. Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
force-pushed
the
dead-code-and-factorization
branch
from
ea46088 to
e454bf2
Compare
| std::string asString(const std::list<std::string> &lstr, const std::string &separator = "\n"); | ||
| template <class Sequence> | ||
| std::string asString(const Sequence &lstr, const std::string &separator = "\n") | ||
| { |
dawagner
added a commit
that referenced
this pull request
Mar 18, 2016
Dead code removal and some factorization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krocard @tcahuzax please review
80.34%