This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Remove CXX compiler verbose flag for swig binding #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
Contributor
|
👎 It breaks: see http://stackoverflow.com/questions/17043088/cmake-build-calling-swig-with-multiple-arguments The correct version would be: and the current makefile is wrong too. |
krocard
force-pushed
the
no_verbose_cxx
branch
from
2dfb3a6 to
8c08423
Compare
Contributor
Author
|
👎 |
`SET_SOURCE_FILES_PROPERTIES(pfw.i PROPERTIES SWIG_FLAGS "-v" "-Wall" "-Werror")` sets 2 variables: - `SWIG_FLAGS="-v"` - `-Wall="-Werror"` which is obviously not what was wanted. Replace by `SET_PROPERTY(SOURCE pfw.i PROPERTY SWIG_FLAGS "-v" "-Wall" "-Werror")` that only sets `SWIG_FLAGS="-v -Wall -Werror"`. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
When compiling swig generated files, the CXX compiler flag list included -v. This leaded to unnecessary log output during compilation. Remove the flag Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Some cmake commands were in big case in the python binding cmake. As all others are in low case, put everything in low case. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
krocard
force-pushed
the
no_verbose_cxx
branch
from
8c08423 to
67e1b82
Compare
Contributor
Author
|
👍 |
dawagner
added a commit
that referenced
this pull request
Feb 17, 2015
Remove CXX compiler verbose flag for swig binding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling swig generated files, the CXX compiler
flag list included -v. This leaded to unnecessary log
output during compilation. =>_Remove the flag.
Some cmake command were in upper case.