This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fix pointer arithmetic instead of concat #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
krocard
force-pushed
the
fix_string+num_concat
branch
2 times, most recently
from
c424890 to
78f76a3
Compare
`"my number " + 5` does not produces `"my number 5"` but rather `"mber "`. If the number was greater than `len(string) + 2` (pointing to the \0 and one past the end in authorized, more in UB) the result would have been undefined behaviour. Transforme the number to std::string using toString. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
krocard
force-pushed
the
fix_string+num_concat
branch
from
78f76a3 to
b80adac
Compare
dawagner
added a commit
that referenced
this pull request
Feb 18, 2015
Fix pointer arithmetic instead of concat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"my number " + 5does not produces"my number 5"but rather"mber ".If the number was greater than
len(string) + 2(pointing to the \0 and one past the end in authorized, more in UB)
the result would have been undefined behaviour.
Concatenate the number with a string stream.