This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Use minidom factory methods in xml coverage generator #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exportToXML was creating an minidom.Element using it's constructor, which is forbidden in the documentation: > Applications should not instantiate the classes themselves; they should use the creator functions available on the Document object. http://docs.python.org/library/xml.dom.minidom.html Since python 3.4 this method no longer works (private interface change) thus the xml coverage generation was broken. Fix by calling the recommended method Document.createElement. See bug: http://bugs.python.org/issue15290 Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Contributor
Author
Contributor
|
Commit seems good to me, however the renaming could be done in another patch even if it makes sense to rename it here since you introduce the "document" variable in this patch. |
Contributor
|
👍 |
dawagner
added a commit
that referenced
this pull request
Feb 13, 2015
Use minidom factory methods in xml coverage generator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exportToXML was creating an minidom.Element using it's constructor, which is forbidden in the documentation:
Since python 3.4 this method no longer works (private interface change) thus the xml coverage generation was broken.
Fix by calling the recommended method Document.createElement.
See bug: http://bugs.python.org/issue15290
Signed-off-by: Kevin Rocard kevin.rocard@intel.com