This repository was archived by the owner on Aug 5, 2022. It is now read-only.
missing std in skeleton #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The skeleton plugin is not compiled when compiling the root pfw project. As a result, when `using namespaces` was removed from the pfw headers the skeleton plugin was left unchecked and unfortunately broken. Fix the missing `std::` by adding them where needed or inserting a `using std::string`. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
…parameter-framework into krocard-missing_std_in_skeleton
The skeleton plugin is an example and as such needs to work out-of-the-box. Make travis build it to ensure we don't break anything. Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
Author
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.