[OSS] - [ROS2OV_Team1] Fixed bash script errors and warnings #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tool Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com>
LewisLiuPub
approved these changes
Mar 4, 2025
Contributor
LewisLiuPub
left a comment
LewisLiuPub
left a comment
There was a problem hiding this comment.
lgtm. thanks for updates.
LewisLiuPub
pushed a commit
that referenced
this pull request
Mar 4, 2025
…tool (#321) Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com>
jb-balaji
added a commit
to jb-balaji/ros2_openvino_toolkit
that referenced
this pull request
Mar 4, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0 ------------------------------------------------------------ * Creating docker container for ROS2 Humble with OpenVINO 2025.0.0 * Enable OV2025 experimental support * Docker file and a header file is updated. Code is compiling without errors and a simple image pipeline demo is run. Detailed testing required. * Minor refactoring of the dockerfile to accept OpenVINO version, add nano package Created the README document to build, setup and run the docker container Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> * fix merging conflicts. Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> * Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321) Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> --------- Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> Co-authored-by: Liu, Wei Zhi <wei.zhi.liu@intel.com>
jb-balaji
added a commit
to jb-balaji/ros2_openvino_toolkit
that referenced
this pull request
Mar 4, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0 ------------------------------------------------------------ * Creating docker container for ROS2 Humble with OpenVINO 2025.0.0 * Enable OV2025 experimental support * Docker file and a header file is updated. Code is compiling without errors and a simple image pipeline demo is run. Detailed testing required. * Minor refactoring of the dockerfile to accept OpenVINO version, add nano package Created the README document to build, setup and run the docker container Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> * fix merging conflicts. Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> * Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321) Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> --------- Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> Co-authored-by: Liu, Wei Zhi <wei.zhi.liu@intel.com>
jb-balaji
added a commit
to jb-balaji/ros2_openvino_toolkit
that referenced
this pull request
Mar 6, 2025
…tool (intel#321) Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com>
jb-balaji
added a commit
to jb-balaji/ros2_openvino_toolkit
that referenced
this pull request
Mar 6, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0 ------------------------------------------------------------ * Creating docker container for ROS2 Humble with OpenVINO 2025.0.0 * Enable OV2025 experimental support * Docker file and a header file is updated. Code is compiling without errors and a simple image pipeline demo is run. Detailed testing required. * Minor refactoring of the dockerfile to accept OpenVINO version, add nano package Created the README document to build, setup and run the docker container Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> * fix merging conflicts. Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> * Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321) Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> --------- Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> Co-authored-by: Liu, Wei Zhi <wei.zhi.liu@intel.com>
jb-balaji
added a commit
to jb-balaji/ros2_openvino_toolkit
that referenced
this pull request
Mar 6, 2025
* ROS2 Humble Docker Container with OpenVINO 2025.0.0 ------------------------------------------------------------ * Creating docker container for ROS2 Humble with OpenVINO 2025.0.0 * Enable OV2025 experimental support * Docker file and a header file is updated. Code is compiling without errors and a simple image pipeline demo is run. Detailed testing required. * Minor refactoring of the dockerfile to accept OpenVINO version, add nano package Created the README document to build, setup and run the docker container Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> * fix merging conflicts. Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> * Fixed bash script all the errors and warnings reported by shellcheck tool (intel#321) Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> --------- Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com> Signed-off-by: Sathiyamoorthi, Jayabalaji <jayabalaji.sathiyamoorthi@intel.com> Signed-off-by: Liu, Wei Zhi <wei.zhi.liu@intel.com> Co-authored-by: Liu, Wei Zhi <wei.zhi.liu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bash script all the errors and warnings reported by shellcheck tool
Signed-off-by: Sathiyamoorthi, Jayabalaji jayabalaji.sathiyamoorthi@intel.com