Skip to content

Conversation

@Wenzel
Copy link
Contributor

@Wenzel Wenzel commented Sep 29, 2025

No description provided.

@Wenzel Wenzel force-pushed the dockerfile_no_root branch 5 times, most recently from 47bf0ac to a11ecf7 Compare October 2, 2025 18:00
@Wenzel Wenzel force-pushed the dockerfile_no_root branch from a11ecf7 to 0890648 Compare October 6, 2025 21:52
@Wenzel Wenzel force-pushed the dockerfile_no_root branch from 0890648 to 24441af Compare October 6, 2025 22:02
@Wenzel Wenzel requested a review from Copilot October 7, 2025 07:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Dockerfile to set a consistent vscode user in both development and production images for the TSFFS project. The changes create a unified user management approach and reorganize the build stages for better maintainability.

  • Introduces a new create-user base stage that creates the vscode user with proper permissions
  • Restructures both tsffs-dev and tsffs-prod stages to inherit from the new user creation stage
  • Adds aggressive cleanup to CI workflow to free up disk space during builds

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Dockerfile Restructures multi-stage build to create vscode user in both dev and prod images, consolidates user creation logic, and fixes file permissions
.github/workflows/ci.yml Adds aggressive cleanup step to remove unused software packages and free disk space

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Wenzel Wenzel merged commit 5dddfd4 into intel:main Oct 7, 2025
22 checks passed
@Wenzel Wenzel deleted the dockerfile_no_root branch October 7, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant