-
Notifications
You must be signed in to change notification settings - Fork 23
update edk2-uefi tutorial #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the edk2-uefi tutorial to improve the build process and documentation. The changes streamline the setup process by automating the copying of necessary files and corpus generation, and update documentation to reflect current version numbers and best practices.
- Refactored the build script to use a loop for copying multiple file extensions and added automatic corpus generation
- Updated documentation with current Simics version numbers and improved syntax highlighting
- Added automatic copying of required files (minimal boot disk and TSFFS header) to the project directory
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/tutorials/edk2-uefi/build.sh | Streamlined file copying with a loop, added corpus generation, and automated copying of required dependencies |
| examples/tutorials/edk2-uefi/Dockerfile | Added quotes around environment variable assignments for consistency |
| examples/tutorials/edk2-uefi/.gitignore | Added entry to ignore the copied tsffs.h header file |
| docs/src/tutorials/edk2-uefi/writing-the-application.md | Updated syntax highlighting from txt to ini and removed unused variable assignment |
| docs/src/tutorials/edk2-uefi/testing-the-application.md | Updated Simics version numbers and improved documentation structure |
| docs/src/tutorials/edk2-uefi/configuring-the-fuzzer.md | Updated syntax highlighting and clarified corpus directory configuration |
| docs/src/tutorials/edk2-uefi/building-the-application.md | Updated documentation to reflect automated file copying and removed manual chmod requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| for file_ext in efi map debug; do | ||
| docker cp \ | ||
| "${CONTAINER_NAME}:/edk2/Tutorial/Build/CryptoPkg/All/DEBUG_GCC/X64/Tutorial/Tutorial/DEBUG/Tutorial.efi" \ |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docker cp command always copies the .efi file regardless of the file_ext variable. The source path should use the variable: Tutorial.${file_ext} instead of hardcoded Tutorial.efi.
| "${CONTAINER_NAME}:/edk2/Tutorial/Build/CryptoPkg/All/DEBUG_GCC/X64/Tutorial/Tutorial/DEBUG/Tutorial.efi" \ | |
| "${CONTAINER_NAME}:/edk2/Tutorial/Build/CryptoPkg/All/DEBUG_GCC/X64/Tutorial/Tutorial/DEBUG/Tutorial.${file_ext}" \ |
aff1d01 to
fc63ff4
Compare
fc63ff4 to
a62021e
Compare
No description provided.