Skip to content

Conversation

@Wenzel
Copy link
Contributor

@Wenzel Wenzel commented Oct 16, 2025

No description provided.

@Wenzel Wenzel requested a review from Copilot October 16, 2025 15:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the edk2-uefi tutorial to improve the build process and documentation. The changes streamline the setup process by automating the copying of necessary files and corpus generation, and update documentation to reflect current version numbers and best practices.

  • Refactored the build script to use a loop for copying multiple file extensions and added automatic corpus generation
  • Updated documentation with current Simics version numbers and improved syntax highlighting
  • Added automatic copying of required files (minimal boot disk and TSFFS header) to the project directory

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
examples/tutorials/edk2-uefi/build.sh Streamlined file copying with a loop, added corpus generation, and automated copying of required dependencies
examples/tutorials/edk2-uefi/Dockerfile Added quotes around environment variable assignments for consistency
examples/tutorials/edk2-uefi/.gitignore Added entry to ignore the copied tsffs.h header file
docs/src/tutorials/edk2-uefi/writing-the-application.md Updated syntax highlighting from txt to ini and removed unused variable assignment
docs/src/tutorials/edk2-uefi/testing-the-application.md Updated Simics version numbers and improved documentation structure
docs/src/tutorials/edk2-uefi/configuring-the-fuzzer.md Updated syntax highlighting and clarified corpus directory configuration
docs/src/tutorials/edk2-uefi/building-the-application.md Updated documentation to reflect automated file copying and removed manual chmod requirement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


for file_ext in efi map debug; do
docker cp \
"${CONTAINER_NAME}:/edk2/Tutorial/Build/CryptoPkg/All/DEBUG_GCC/X64/Tutorial/Tutorial/DEBUG/Tutorial.efi" \
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker cp command always copies the .efi file regardless of the file_ext variable. The source path should use the variable: Tutorial.${file_ext} instead of hardcoded Tutorial.efi.

Suggested change
"${CONTAINER_NAME}:/edk2/Tutorial/Build/CryptoPkg/All/DEBUG_GCC/X64/Tutorial/Tutorial/DEBUG/Tutorial.efi" \
"${CONTAINER_NAME}:/edk2/Tutorial/Build/CryptoPkg/All/DEBUG_GCC/X64/Tutorial/Tutorial/DEBUG/Tutorial.${file_ext}" \

Copilot uses AI. Check for mistakes.
@Wenzel Wenzel force-pushed the tutorials/edk2-uefi/update branch from aff1d01 to fc63ff4 Compare October 16, 2025 15:29
@Wenzel Wenzel force-pushed the tutorials/edk2-uefi/update branch from fc63ff4 to a62021e Compare October 16, 2025 15:31
@Wenzel Wenzel merged commit 5515d6d into intel:main Oct 17, 2025
22 checks passed
@Wenzel Wenzel deleted the tutorials/edk2-uefi/update branch October 17, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant