Skip to content

Conversation

@Wenzel
Copy link
Contributor

@Wenzel Wenzel commented Oct 24, 2025

If proxy settings are configured in ~/.docker/config.json, redeclaring the proxy env vars as ARG allow us to override them in all build stages.

@Wenzel Wenzel requested a review from Copilot October 24, 2025 11:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables overriding Docker client proxy settings configured in ~/.docker/config.json by declaring proxy environment variables as ARG directives in the Dockerfile.

Key Changes:

  • Added proxy ARG declarations (http_proxy, https_proxy, no_proxy) at the top of the Dockerfile
  • Redeclared these ARGs in each build stage to ensure proxy settings propagate throughout the multi-stage build

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Wenzel Wenzel merged commit 2b01fe7 into intel:main Oct 27, 2025
22 checks passed
@Wenzel Wenzel deleted the dockerfile/override_proxy branch October 27, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant