Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

Conversation

kinyat
Copy link
Contributor

@kinyat kinyat commented Nov 14, 2018

The following MUST be checked prior to approval. If not relevant to your MR, remove the line from your description.

  • Examples have been provided for any new components or functionality
  • The styleguide.config.js has been updated to show the component in the ui-component page
  • Test Coverage for any new or updated functionality
  • Updated components have been tested locally in lapis and SPA and work as expected
  • This PR has been tagged with PATCH, MINOR, or MAJOR.
  • The component has data-component-type and data-component-context attributes following the standard

@kinyat kinyat self-assigned this Nov 14, 2018
@kinyat kinyat requested a review from callum-p November 14, 2018 06:50
@kinyat kinyat added the PATCH Bug fixes or improvements with backward compatible changes label Nov 14, 2018
@kinyat kinyat merged commit 9000981 into develop Nov 14, 2018
@kinyat kinyat deleted the doc/npm-deploy branch November 15, 2018 04:23
@intellihrci intellihrci mentioned this pull request Nov 15, 2018
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PATCH Bug fixes or improvements with backward compatible changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants