Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

[INT-3634] Fix IOS scrolling in modals (again) (hopefully for good) #46

Merged
merged 2 commits into from
Nov 20, 2018
Merged

[INT-3634] Fix IOS scrolling in modals (again) (hopefully for good) #46

merged 2 commits into from
Nov 20, 2018

Conversation

seanmanson
Copy link
Contributor

@seanmanson seanmanson commented Nov 20, 2018 •
edited
Loading

INT-3634

The following MUST be checked prior to approval. If not relevant to your MR, remove the line from your description.

  • Examples have been provided for any new components or functionality
  • The styleguide.config.js has been updated to show the component in the ui-component page
  • Test Coverage for any new or updated functionality
  • Updated components have been tested locally in lapis and SPA and work as expected
  • This PR has been tagged with PATCH, MINOR, or MAJOR.
  • The component has data-component-type and data-component-context attributes following the standard

@seanmanson seanmanson added the PATCH Bug fixes or improvements with backward compatible changes label Nov 20, 2018
@seanmanson seanmanson self-assigned this Nov 20, 2018
@MichaelDevenish MichaelDevenish merged commit 6a81d2a into develop Nov 20, 2018
@seanmanson seanmanson deleted the INT-3634-fixup-ios-scrolling branch November 20, 2018 23:11
@intellihrci intellihrci mentioned this pull request Nov 20, 2018
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MichaelDevenish MichaelDevenish MichaelDevenish approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seanmanson seanmanson

Labels

PATCH Bug fixes or improvements with backward compatible changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seanmanson @MichaelDevenish