This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Add list design doc #922
Merged
Add list design doc #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INT-14085
Contributor
Author
|
|
Contributor
andrewhillcode
left a comment
andrewhillcode
left a comment
There was a problem hiding this comment.
I'll finish this review tomorrow
docs/List.md
Outdated
Comment on lines
1
to
4
| List are used for listing items on page | ||
|
|
||
| [Card](/#/Content/Cards/Card) is used for list item instead of smart list | ||
| List should be limited to **10** cards each except person profile (20 cards) |
Contributor
There was a problem hiding this comment.
Don't need to mention smart lists.
Page content generally takes the forms of lists of items.
As a general rule, we display data using paginated lists of 10 Card components per page.
There are exceptions but please run this through the frontend/design guild before committing to any designs.
andrewhillcode
approved these changes
Jan 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT-14085
The following MUST be checked prior to approval. If not relevant to your PR, remove the line from your description.
styleguide.config.jshas been updated to show examples/new functionality for the component