Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

Conversation

andrewhillcode
Copy link
Contributor

The following MUST be checked prior to approval. If not relevant to your PR, remove the line from your description.

  • The styleguide.config.js has been updated to show examples/new functionality for the component
  • Test Coverage for any new or updated functionality
  • New and updated components have been tested locally in lapis and SPA and work as expected
  • This PR has been tagged with PATCH, MINOR, or MAJOR.
  • The component has data-component-type and data-component-context attributes following the standard
  • You have requested a cross-team review on this component so everyone knows it exists

intellihr/engineering/team-kiki/team-kiki#14651
intellihr/engineering/team-kiki/team-kiki#14651
intellihr/engineering/team-kiki/team-kiki#14651
@andrewhillcode andrewhillcode added the MINOR Extra functionality with backward compatible changes label Mar 10, 2021
@andrewhillcode andrewhillcode self-assigned this Mar 10, 2021
@andrewhillcode andrewhillcode changed the title Href on FontAwesomeIconButton and minor style fixes for Avatar and Section Add href prop for FontAwesomeIconButton and minor style fixes for Avatar and Section Mar 10, 2021
Copy link
Contributor

@KaitlynPickard KaitlynPickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

:local(.Avatar) {
display: inline-block;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it affect the existing avatar?

Copy link
Contributor Author

@andrewhillcode andrewhillcode Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any change with any of the ui-components that use Avatar

@andrewhillcode andrewhillcode merged commit 9f729e4 into develop Mar 10, 2021
@andrewhillcode andrewhillcode deleted the intellihr/engineering/team-kiki/team-kiki#14651 branch March 10, 2021 04:45
@intellibot-access intellibot-access bot mentioned this pull request Mar 10, 2021
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

MINOR Extra functionality with backward compatible changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants