Skip to content

refactor: add missed fields for Channel and Tags #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2022
Merged

refactor: add missed fields for Channel and Tags #1193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions interactions/api/models/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ async def __aexit__(self, exc_type, exc_val, exc_tb):


@define()
class Tags(ClientSerializerMixin): # helpers, hehe :D
class Tags(ClientSerializerMixin):
"""
.. versionadded:: 4.3.2

Expand All @@ -310,17 +310,23 @@ class Tags(ClientSerializerMixin): # helpers, hehe :D
:ivar str name: Name of the tag. The limit is up to 20 characters.
:ivar int id: ID of the tag. Can also be 0 if manually created.
:ivar bool moderated: A boolean denoting whether this tag can be removed/added by moderators with the :attr:`.Permissions.MANAGE_THREADS` permission.
:ivar Optional[Emoji] emoji: The emoji to represent the tag, if any.

:ivar Optional[str] emoji_name: The unicode character of the emoji.
:ivar Optional[Snowflake] emoji_id: The id of a guild's custom emoji.
"""

# TODO: Rename these to discord-docs
name: str = field()
id: int = field()
moderated: bool = field()
emoji: Optional[Emoji] = field(converter=Emoji, default=None)
emoji_name: Optional[str] = field(default=None)
emoji_id: Optional[Snowflake] = field(converter=Snowflake, default=None)

# Maybe on post_attrs_init replace emoji object with one from cache for name population?
@property
def emoji(self) -> Emoji:
"""
Returns an emoji of tag.
"""
return Emoji(name=self.emoji_name, id=self.emoji_id, _client=self._client)

async def delete(
self, channel_id: Union[int, str, Snowflake, "Channel"] # discord, why :hollow:
Expand Down Expand Up @@ -423,6 +429,7 @@ class Channel(ClientSerializerMixin, IDMixin):
:ivar Optional[int] total_message_sent: Number of messages ever sent in a thread.
:ivar Optional[int] default_thread_slowmode_delay: The default slowmode delay in seconds for threads, if this channel is a forum.
:ivar Optional[List[Tags]] available_tags: Tags in a forum channel, if any.
:ivar Optional[List[Snowflake]] applied_tags: The IDs of tags that have been applied to a thread, if any.
:ivar Optional[Emoji] default_reaction_emoji: Default reaction emoji for threads created in a forum, if any.
"""

Expand Down Expand Up @@ -474,7 +481,8 @@ class Channel(ClientSerializerMixin, IDMixin):
default_thread_slowmode_delay: Optional[int] = field(default=None, repr=False)
available_tags: Optional[List[Tags]] = field(
converter=convert_list(Tags), default=None, add_client=True
) # eh?
)
applied_tags: Optional[List[Snowflake]] = field(converter=convert_list(Snowflake), default=None)
default_reaction_emoji: Optional[Emoji] = field(converter=Emoji, default=None)

def __attrs_post_init__(self): # sourcery skip: last-if-guard
Expand Down