Skip to content

fix: few bugs with object serialization #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2022
Merged

fix: few bugs with object serialization #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9162cd
fix: bug with role related events
Damego Dec 18, 2022
cb5f55f
fix: not ignore NoneType values on update
Damego Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions interactions/api/gateway/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,7 @@ def _dispatch_discord_event(self, event: str, data: dict) -> None:

guild_obj = guild_model = None
if model is GuildRole:
guild_obj = (
Role(**role_data, _client=self._http)
if (role_data := data.get("role"))
else None
)
guild_obj = obj.role
guild_model = Role
elif model is GuildMember:
guild_obj = Member(**data)
Expand Down
3 changes: 0 additions & 3 deletions interactions/utils/attrs_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,6 @@ def update(self, kwargs_dict: dict = None, /, **other_kwargs):
self._extras[name] = value
continue

if value is None:
continue

setattr(
self, name, converter(value) if (converter := attribs[name].converter) else value
)
Expand Down