Skip to content

feat: allow disabling autodefer through auto_defer methods #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023
Merged

feat: allow disabling autodefer through auto_defer methods #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f69563
feat: allow disabling autodefer through auto_defer methods
AstreaTSS Mar 10, 2023
ee5b15e
fix: oops
AstreaTSS Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions interactions/models/internal/application_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,11 +1252,14 @@ def wrapper(func: SlashCommandT) -> SlashCommandT:
return wrapper


def auto_defer(ephemeral: bool = False, time_until_defer: float = 0.0) -> Callable[[InterCommandT], InterCommandT]:
def auto_defer(
enabled: bool = True, ephemeral: bool = False, time_until_defer: float = 0.0
) -> Callable[[InterCommandT], InterCommandT]:
"""
A decorator to add an auto defer to a application command.

Args:
enabled: Should the command be deferred automatically
ephemeral: Should the command be deferred as ephemeral
time_until_defer: How long to wait before deferring automatically

Expand All @@ -1265,7 +1268,7 @@ def auto_defer(ephemeral: bool = False, time_until_defer: float = 0.0) -> Callab
def wrapper(func: InterCommandT) -> InterCommandT:
if hasattr(func, "cmd_id"):
raise ValueError("auto_defer decorators must be positioned under a slash_command decorator")
func.auto_defer = AutoDefer(enabled=True, ephemeral=ephemeral, time_until_defer=time_until_defer)
func.auto_defer = AutoDefer(enabled=enabled, ephemeral=ephemeral, time_until_defer=time_until_defer)
return func

return wrapper
Expand Down
5 changes: 3 additions & 2 deletions interactions/models/internal/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,17 @@ def drop(self) -> None:
self.bot.dispatch(events.ExtensionUnload(self))
self.bot.logger.debug(f"{self.name} has been drop")

def add_ext_auto_defer(self, ephemeral: bool = False, time_until_defer: float = 0.0) -> None:
def add_ext_auto_defer(self, enabled: bool = True, ephemeral: bool = False, time_until_defer: float = 0.0) -> None:
"""
Add a auto defer for all commands in this extension.

Args:
enabled: Should the command be deferred automatically
ephemeral: Should the command be deferred as ephemeral
time_until_defer: How long to wait before deferring automatically

"""
self.auto_defer = models.AutoDefer(enabled=True, ephemeral=ephemeral, time_until_defer=time_until_defer)
self.auto_defer = models.AutoDefer(enabled=enabled, ephemeral=ephemeral, time_until_defer=time_until_defer)

def add_ext_check(self, coroutine: Callable[["BaseContext"], Awaitable[bool]]) -> None:
"""
Expand Down