Skip to content

fix: emoji deletion error on guild leave #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2023
Merged

fix: emoji deletion error on guild leave #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6364bca
fix: emoji deletion error on guild leave
Mar 11, 2023
7def142
ci: correct from checks.
pre-commit-ci[bot] Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interactions/client/smart_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ def delete_guild(self, guild_id: "Snowflake_Type") -> None:
[self.delete_member(m.id, guild_id) for m in guild.members]
[self.delete_role(r) for r in guild.roles]
if self.enable_emoji_cache: # todo: this is ungodly slow, find a better way to do this
for emoji in self.emoji_cache:
for emoji in self.emoji_cache.values():
if emoji._guild_id == guild_id: # noqa
self.delete_emoji(emoji)

Expand Down
4 changes: 3 additions & 1 deletion interactions/models/internal/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,9 @@ async def defer(self, *, ephemeral: bool = False, edit_origin: bool = False) ->
raise RuntimeError("Interaction has already been responded to.")

payload = {
"type": CallbackType.DEFERRED_CHANNEL_MESSAGE_WITH_SOURCE if not edit_origin else CallbackType.DEFERRED_UPDATE_MESSAGE
"type": CallbackType.DEFERRED_CHANNEL_MESSAGE_WITH_SOURCE
Copy link
Contributor

@LordOfPolls LordOfPolls Mar 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not appear related to what you are trying to resolve - please rebase your pr before it can be merged

Copy link
Contributor Author

@Speedcup Speedcup Mar 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aint my change, this has been automatically formatted by pre-commit-ci[

Copy link
Contributor

@LordOfPolls LordOfPolls Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okeydoke, ill ignore it then

if not edit_origin
else CallbackType.DEFERRED_UPDATE_MESSAGE
}
if ephemeral:
if edit_origin:
Expand Down