Skip to content

Conversation

@LordOfPolls
Copy link
Contributor

About

Replaces flake8 and autoflake with Ruff. A substantially faster linter with feature parity with the former.
This mirrors the config used by flake8, plus some extra configs unique to Ruff.

I have ensured this pr resolves all warnings & errors raised by ruff... most of which it resolved itself with the --fix flag
image

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.
  • I have added the versionadded, versionchanged and deprecated to any new or changed user-facing function I committed.

Pull-Request specification

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

@LordOfPolls LordOfPolls requested a review from silasary March 13, 2023 09:55
Copy link
Member

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, nice job

@LordOfPolls LordOfPolls merged commit c6eb99e into 5.x Mar 13, 2023
@LordOfPolls LordOfPolls deleted the ruff branch March 13, 2023 10:51
LordOfPolls added a commit that referenced this pull request Mar 13, 2023
* ci: define ruff config

* refactor: run ruff autofix

* ci: add D404 & D203 to excludes

* refactor: resolve remaining ruff warnings

* ci: replace autoflake and flake8 with ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants