Skip to content

Conversation

@LilSpazJoekp
Copy link
Contributor

About this pull request

This cleans up a few things in the codebase.

Changes

Checklist

  • I've run the pre_push.py script to format and lint code.
  • I've checked this pull request runs on Python 3.6.X.
  • This fixes something in Issues.
    • Issue:
  • This adds something new.
  • There is/are breaking change(s).
  • (If required) Relevant documentation has been updated/added.
  • This is not a code change. (README, docs, etc.)

@eunwoo1104 eunwoo1104 added enhancement New feature or request pending Pending approve labels May 14, 2021
@quirky-bluejay
Copy link
Contributor

quirky-bluejay commented Jun 1, 2021

@LilSpazJoekp new changes need to be merged 🙂
Also what's the reasoning for ci linting on three os's?

@LilSpazJoekp
Copy link
Contributor Author

Will do. Since pre_push.py can be ran on those three OSs, it would catch any issues people would have running that.

@LilSpazJoekp
Copy link
Contributor Author

This is ready now.

@LilSpazJoekp LilSpazJoekp changed the base branch from master to components June 6, 2021 16:43
@LilSpazJoekp
Copy link
Contributor Author

You will have to ignore CI errors because the doc strings in components isn't valid reStructuredText.

@LordOfPolls LordOfPolls merged commit da4fb0f into interactions-py:components Jun 6, 2021
@LilSpazJoekp LilSpazJoekp deleted the cleanup branch June 6, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pending Pending approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants