-
Notifications
You must be signed in to change notification settings - Fork 185
General cleanup and format code with black #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwoo1110
reviewed
May 3, 2021
Contributor
|
@LilSpazJoekp new changes need to be merged 🙂 |
Contributor
Author
|
Will do. Since pre_push.py can be ran on those three OSs, it would catch any issues people would have running that. |
Contributor
Author
|
This is ready now. |
…t.py are opened, added license parameter
Many of these should be placed in a global gitignore: https://help.github.com/en/github/using-git/ignoring-files#create-a-global-gitignore
Contributor
Author
|
You will have to ignore CI errors because the doc strings in components isn't valid reStructuredText. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this pull request
This cleans up a few things in the codebase.
Changes
__version__andBASEconstants todiscord_slash/const.pyfor easier access when they need changed.gitignoresetup.pyfile since there are now extra requirements only needed when linting or building docsconst.pyREADME.mdandconst.pyare accessed to prevent issues in rare instancessetupcallpre_push.pythat will format and lint code automatically for contributorspre_push.pyin pull request templateisinstanceas suggested by flake8: https://github.com/eunwoo1104/discord-py-slash-command/blob/d5cba045a60aa5f9e3e16d16e7a4520fbdd31e3c/discord_slash/utils/manage_commands.py#L217Checklist
pre_push.pyscript to format and lint code.Python 3.6.X.