Skip to content

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Jun 12, 2021

About this pull request

This PR essentially warns the user that the command(s) that uses string snowflake IDs as a guild_ids arg does not work and therefore result in "This interaction failed".

Changes

Added a guilds_id check if all of them are ints on both the regular slash client end and on the cog_ext end, and provided an Exception upon check failure.

Checklist

Copy link
Contributor

@quirky-bluejay quirky-bluejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should raise a custom exception, for example like the others that are in .error.
Also not too sure about this one, but shouldn't all development be targeted at the components branch?
I wouldn't count this a breaking change as it doesn't 'work' when ids are strings anyways.

@FayeDel
Copy link
Collaborator Author

FayeDel commented Jun 13, 2021

To be completely honest, I wasn't too sure if it would be targeted towards component because I presumed that it was for components and its own spiel. That and, I had to second guess marking if it was a breaking change, but the tip helps in console so I marked it there.

@LordOfPolls
Copy link
Contributor

I'm happy with these changes, but can you please make them for the components branch, as per what cat said

@FayeDel FayeDel changed the base branch from master to components June 14, 2021 17:17
FayeDel and others added 2 commits June 14, 2021 13:23
(Wonky switch branch problem fix, fix accidental README line deletion)
@LordOfPolls
Copy link
Contributor

Is this complete?

@FayeDel
Copy link
Collaborator Author

FayeDel commented Jun 17, 2021

This is switched to components with its own respective changes, yes. Should have mentioned that earlier, my bad

@LordOfPolls
Copy link
Contributor

LordOfPolls commented Jun 17, 2021

Please may you run pre_push.py, rn your pr is failing due to formatting issues

@FayeDel
Copy link
Collaborator Author

FayeDel commented Jun 17, 2021

Ran the PR and formatted (double checked even without the file and it seems to be fine).

@LordOfPolls
Copy link
Contributor

Merging, thanks for contributing, please dm me on discord for the role

@LordOfPolls LordOfPolls merged commit cd4e8bf into interactions-py:components Jun 17, 2021
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@interactions-py interactions-py locked as too heated and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants