-
Notifications
You must be signed in to change notification settings - Fork 187
String Snowflake ID in decorator args #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should raise a custom exception, for example like the others that are in .error.
Also not too sure about this one, but shouldn't all development be targeted at the components branch?
I wouldn't count this a breaking change as it doesn't 'work' when ids are strings anyways.
|
To be completely honest, I wasn't too sure if it would be targeted towards component because I presumed that it was for components and its own spiel. That and, I had to second guess marking if it was a breaking change, but the tip helps in console so I marked it there. |
|
I'm happy with these changes, but can you please make them for the components branch, as per what cat said |
(Wonky switch branch problem fix, fix accidental README line deletion)
|
Is this complete? |
|
This is switched to components with its own respective changes, yes. Should have mentioned that earlier, my bad |
|
Please may you run |
|
Ran the PR and formatted (double checked even without the file and it seems to be fine). |
|
Merging, thanks for contributing, please dm me on discord for the role |
Toricane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
About this pull request
This PR essentially warns the user that the command(s) that uses string snowflake IDs as a guild_ids arg does not work and therefore result in "This interaction failed".
Changes
Added a
guilds_idcheck if all of them are ints on both the regular slash client end and on thecog_extend, and provided an Exception upon check failure.Checklist
Python 3.6.X.