Skip to content

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Sep 6, 2021

About this pull request

This PR is essentially a "mega-PR" in the sense that this will carry out most of the bot endpoints (except some of Voice).
This PR also:

  • Introduces our own HTTP client, and subsequently is used to connect to Discord's API including WebSockets.
  • Changes discord.py imports from v3.0.2 to our v4.0.0 models.
  • Fixes documentation (was pointing to deprecated discord API sub docs)
  • Implement command decorators using our HTTP Client.

Changes

(self explanatory)

Checklist

  • I've run the pre_push.py script to format and lint code.
  • I've checked this pull request runs on Python 3.6.X.
  • This fixes something in Issues.
  • This adds something new.
  • There is/are breaking change(s).
  • (If required) Relevant documentation has been updated/added.
  • This is not a code change. (README, docs, etc.)

This switches gateway's URL retrieval to rely on the HTTP client.
(For reference only, the d.py imports are commented out)
@i0bs
Copy link
Contributor

i0bs commented Sep 6, 2021

mega? 😳

@i0bs i0bs self-requested a review September 6, 2021 19:37
@i0bs i0bs mentioned this pull request Sep 8, 2021
7 tasks
# Conflicts:
#	interactions/api/gateway.py
# Conflicts:
#	interactions/api/gateway.py
#	interactions/api/models/guild.py
#	interactions/api/models/message.py
Add friendly `send_message`, "add"/modify endpoints to have responses work properly.
@i0bs
Copy link
Contributor

i0bs commented Sep 9, 2021

when can I review? are all/most endpoints coded in?

(also, partly create new JSON error handler)
Implement unban, guild member modification, rest of webhook, channel delete, message pin/unpin

also.. voice regions :)
Finish emoji endpoints. Also implement guild previews, widgets, integrations, invites, welcome screens, guild roles, bans + low level adding users, and estimating prune count.
* For some reason, it didn't merge correctly because of pre-commit's flake8. flow why you do dis
Also, guild templates are a thing.
@FayeDel
Copy link
Collaborator Author

FayeDel commented Sep 20, 2021

As of right now (i.e., a3da2e6) sets all of the major endpoints (excluding some user-only based ones). All of the functionality is there, but it's optional to reorganise them and/or their docs when it's used.

@FayeDel FayeDel marked this pull request as ready for review September 20, 2021 23:48
@i0bs i0bs merged commit 15022ab into interactions-py:unstable Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants