refactor: create an extra function for command payload checking #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i0bs
approved these changes
Feb 18, 2022
i0bs
pushed a commit
that referenced
this pull request
Feb 25, 2022
* a * refactor: create an extra function for command payload checking * refactor: extract command checking into seperate function * fix!: change convertion and prevent NoneType error * refactor: update regex to not allow uppercase letters * refactor: update regex * refactor: add check for context menus and fix typo * fix!: add missing ``not`` * Add check for duplicated option names on same command * refactor: update regex in pyi * refactor: correct description check * refactor: check for `**kwargs` in coro check * refactor: indent debug strings to create a visual separation * remove leftover # * refactor: correct logging statement * fix!: option parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.- [ ] issue: [REQUEST] create a function for command checking #527