Skip to content

fix: Add str arg support for modals in extensions, fix headers. #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

fix: Add str arg support for modals in extensions, fix headers. #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion interactions/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,8 @@ def __new__(cls, client: Client, *args, **kwargs) -> "Extension":
func = client.modal(*args, **kwargs)(func)

modal = kwargs.get("modal") or args[0]
modal_name = f"modal_{modal.custom_id}"
_modal_id: str = modal.custom_id if isinstance(modal, Modal) else modal
modal_name = f"modal_{_modal_id}"

listeners = self._listeners.get(modal_name, [])
listeners.append(func)
Expand Down
4 changes: 2 additions & 2 deletions interactions/client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ def extension_command(
default_permission: Optional[bool] = None,
): ...
def extension_listener(name=None) -> Callable[..., Any]: ...
def extension_component(component: Union[Button, SelectMenu]) -> Callable[..., Any]: ...
def extension_component(component: Union[Button, SelectMenu, str]) -> Callable[..., Any]: ...
def extension_autocomplete(
name: str, command: Union[ApplicationCommand, int]
) -> Callable[..., Any]: ...
def extension_modal(modal: Modal) -> Callable[..., Any]: ...
def extension_modal(modal: Union[Modal, str]) -> Callable[..., Any]: ...
def extension_message_command(
*,
name: Optional[str] = None,
Expand Down