Skip to content

fix!: member role attr #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 1, 2022
Merged

fix!: member role attr #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b79405
fix!: fix EmbedImageStruct serialization
EepyElvyra Feb 28, 2022
bf79b5d
fix!: Button emoji serialization
EepyElvyra Feb 28, 2022
a429ffe
fix!: message serialization in context
EepyElvyra Feb 28, 2022
7371906
fix!: Role serialization if roles not present
EepyElvyra Mar 1, 2022
91917c0
Merge branch 'unstable' into fix_member_role_attr
EepyElvyra Mar 1, 2022
0381ca8
Merge branch 'unstable' into fix_member_role_attr
EepyElvyra Mar 1, 2022
8d7bd44
Update interactions/api/models/member.pyi
EepyElvyra Mar 1, 2022
83d4580
Merge branch 'unstable' into fix_member_role_attr
i0bs Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions interactions/api/models/member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,11 @@ def __init__(self, **kwargs):
else None
)

self.roles = [
role_id if isinstance(role_id, int) else int(role_id) for role_id in self.roles
]
self.roles = (
[role_id if isinstance(role_id, int) else int(role_id) for role_id in self.roles]
if self._json.get("roles")
else None
)

if not self.avatar and self.user:
self.avatar = self.user.avatar
Expand Down
2 changes: 1 addition & 1 deletion interactions/api/models/member.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Member(DictSerializerMixin):
user: Optional[User]
nick: Optional[str]
avatar: Optional[str]
roles: List[Role]
roles: List[int]
joined_at: datetime
premium_since: datetime
deaf: bool
Expand Down