feat: Adding icon_url property for returning the guild's icon under api.models.guild.Guild
#680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pi.models.guild.Guild
Contributor
|
dont you need to check for MISSING instead of None |
Contributor
Author
|
Huh? I tested whenever when guild has no icon and the library returned |
Contributor
|
|
Contributor
|
ok that makes sense |
AstreaTSS
reviewed
Mar 29, 2022
Contributor
Author
|
@Astrea49 All done with the next commit. |
Contributor
Author
|
Closed due to conflict. |
8 tasks
Contributor
|
interesting
…On Mon, Mar 28, 2022, 09:48 Blue ***@***.***> wrote:
Huh? I tested whenever when guild has no icon and the library returned
None in the icon hash, so if not None can be used as well, since it is
still None anyway.
—
Reply to this email directly, view it on GitHub
<#680 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVEJTHADQHUM4WSILXNEA2TVCHPHHANCNFSM5R23BA3Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is for adding
icon_urlproperty for returning the guild's icon underapi.models.guild.Guild, which is currently not available and make it harder for users to get the guild's icon URL for different purposes, such as adding guild's icon into an embed message.Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.icon_urlproperty for returning the guild's icon under api.models.guild.Guild #679