Skip to content

Add set_video() helper to the embed #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2022
Merged

Add set_video() helper to the embed #690

merged 6 commits into from
Mar 31, 2022

Conversation

@mAxYoLo01
Copy link
Contributor

@mAxYoLo01 mAxYoLo01 commented Mar 31, 2022

About

Back when Embed helper methods were implemented, it looks like the video one was not added

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EepyElvyra EepyElvyra merged commit 567f32a into interactions-py:unstable Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EepyElvyra EepyElvyra EepyElvyra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mAxYoLo01 @EepyElvyra