ref: Improved error handler #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore!: pre-release for 4.1.1-rc.1
This file was actually cloned outside of the client directory in a PR that had not appropriately adjusted to the new architectural layout of the library.
chore!: release 4.2.0
chore!: release 4.2.1
This is an executive decision made between Delta and I. We will be forcing a version 4.0 push onto our old branch to help transition old users using v3 to our new project. This does not necessarily mean this branch will now be receiving updates along with the rest. The goal is to make our current branch used as much as possible.
Fix error raise
refactor: Change all imports and `raise`s to `LibraryException`
8 tasks
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
1 task
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
Toricane
suggested changes
Jun 12, 2022
Contributor
Toricane
left a comment
Toricane
left a comment
There was a problem hiding this comment.
Running Sphinx v5.0.1
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/envs/848/lib/python3.8/site-packages/sphinx/config.py", line 343, in eval_config_file
exec(code, namespace)
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/docs/conf.py", line 18, in <module>
from interactions.base import __version__
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/__init__.py", line 12, in <module>
from .client import * # noqa: F401 F403 isort: skip
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/client/__init__.py", line 8, in <module>
from .context import * # noqa: F401 F403
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/client/context.py", line 4, in <module>
from ..api import InteractionException
ImportError: cannot import name 'InteractionException' from 'interactions.api' (/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/api/__init__.py)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/envs/848/lib/python3.8/site-packages/sphinx/cmd/build.py", line 272, in build_main
app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/envs/848/lib/python3.8/site-packages/sphinx/application.py", line 202, in __init__
self.config = Config.read(self.confdir, confoverrides or {}, self.tags)
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/envs/848/lib/python3.8/site-packages/sphinx/config.py", line 165, in read
namespace = eval_config_file(filename, tags)
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/envs/848/lib/python3.8/site-packages/sphinx/config.py", line 356, in eval_config_file
raise ConfigError(msg % traceback.format_exc()) from exc
sphinx.errors.ConfigError: There is a programmable error in your configuration file:
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/envs/848/lib/python3.8/site-packages/sphinx/config.py", line 343, in eval_config_file
exec(code, namespace)
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/docs/conf.py", line 18, in <module>
from interactions.base import __version__
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/__init__.py", line 12, in <module>
from .client import * # noqa: F401 F403 isort: skip
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/client/__init__.py", line 8, in <module>
from .context import * # noqa: F401 F403
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/client/context.py", line 4, in <module>
from ..api import InteractionException
ImportError: cannot import name 'InteractionException' from 'interactions.api' (/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/api/__init__.py)
Configuration error:
There is a programmable error in your configuration file:
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/envs/848/lib/python3.8/site-packages/sphinx/config.py", line 343, in eval_config_file
exec(code, namespace)
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/docs/conf.py", line 18, in <module>
from interactions.base import __version__
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/__init__.py", line 12, in <module>
from .client import * # noqa: F401 F403 isort: skip
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/client/__init__.py", line 8, in <module>
from .context import * # noqa: F401 F403
File "/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/client/context.py", line 4, in <module>
from ..api import InteractionException
ImportError: cannot import name 'InteractionException' from 'interactions.api' (/home/docs/checkouts/readthedocs.org/user_builds/interactionspy/checkouts/848/interactions/api/__init__.py)
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fbcf709d6a0>Read the Docs build failed lol
Contributor
Saw it, I'm on making a pr |
Contributor
Author
|
Oh boy, ok I'll fiddle with it |
refactor: Change all imports and `raise`s to `LibraryException`
EepyElvyra
approved these changes
Jun 12, 2022
Contributor
EepyElvyra
left a comment
EepyElvyra
left a comment
There was a problem hiding this comment.
I agree with toricane
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request rewrites the error handler to properly parse and print out a formatted error message.
We can all agree the 50035 is annoying. The information is extremely vague, unless you turn on debug logging. This fix aims to change that
Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.