Skip to content

feat: Add audit log object #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 22, 2022
Merged

feat: Add audit log object #952

merged 13 commits into from
Jul 22, 2022

Conversation

@EepyElvyra
Copy link
Contributor

@EepyElvyra EepyElvyra commented Jul 21, 2022

About

This pull request implements the audit log object

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EepyElvyra EepyElvyra added documentation Improvements or additions to documentation enhancement New feature or request priority This Issue/PR must be resolved first before accepting any others labels Jul 21, 2022
@EepyElvyra EepyElvyra changed the base branch from stable to unstable July 21, 2022 20:07
@mAxYoLo01
Copy link
Contributor

mAxYoLo01 commented Jul 21, 2022

I feel like your file should be named audit_log.py so that Python gods are happy with the naming.

@EepyElvyra
Copy link
Contributor Author

EepyElvyra commented Jul 21, 2022

I feel like your file should be named audit_log.py so that Python gods are happy with the naming.

I named it as I named the scheduled event http file before xD

@EepyElvyra EepyElvyra marked this pull request as ready for review July 22, 2022 19:59
@EepyElvyra EepyElvyra enabled auto-merge (squash) July 22, 2022 20:09
Toricane
Toricane suggested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

@EepyElvyra
Copy link
Contributor Author

EepyElvyra commented Jul 22, 2022

Some suggestions

Done

@EepyElvyra EepyElvyra requested a review from Toricane July 22, 2022 22:10
Toricane
Toricane suggested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was not done

EepyElvyra and others added 2 commits July 23, 2022 01:09
@EepyElvyra @Toricane
Update interactions/api/models/guild.py
5923691 
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
@EepyElvyra @Toricane
Update interactions/api/models/guild.py
b7f8c2c 
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
@EepyElvyra
Copy link
Contributor Author

EepyElvyra commented Jul 22, 2022

No, it was not done

Forgot about those, thanks 😅

@EepyElvyra EepyElvyra requested a review from Toricane July 22, 2022 23:09
@EepyElvyra EepyElvyra merged commit 10ca65a into interactions-py:unstable Jul 22, 2022
Toricane
Toricane approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EepyElvyra EepyElvyra deleted the add_audit_log_helpers branch July 22, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AstreaTSS AstreaTSS Awaiting requested review from AstreaTSS

@Catalyst4222 Catalyst4222 Awaiting requested review from Catalyst4222

@FayeDel FayeDel Awaiting requested review from FayeDel

1 more reviewer

@Toricane Toricane Toricane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request priority This Issue/PR must be resolved first before accepting any others

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EepyElvyra @mAxYoLo01 @Toricane