Skip to content

Conversation

@fbouliane
Copy link
Contributor

hides warning such has below in the projects using config-probe.
This will make sure that config-probe uses the safe yaml load version.
I don't see a valid reason to have injected code in your configuration
ifile.

This is a possibly breaking change.

YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated,
as the default Loader is unsafe.

Please read https://msg.pyyaml.org/load for full details.

hides warning such has below in the projects using config-probe.
This will make sure that config-probe uses the safe yaml load version.
I don't see a valid reason to have injected code in your configuration
ifile.

This is a possibly breaking change.

YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated,
as the default Loader is unsafe.

Please read https://msg.pyyaml.org/load for full details.
Copy link
Contributor

@lindycoder lindycoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests passes i'm good

Copy link
Contributor

@lindycoder lindycoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on travis

@lindycoder lindycoder merged commit dc290ae into internap:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants