Ability to use POST as default request method
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST request `body` is now verified in tests Also fixes code so the example in the README works
|
|
||
| def init(url, user, password, timeout=60): | ||
| return UbersmithApi(url, user, password, timeout) | ||
| def init(url, user, password, timeout=60, use_http_post=False): |
There was a problem hiding this comment.
Please document this new parameter and what it does.
Improve Readme file
|
Updated according to comments |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter
use_http_post=Trueinubersmith_client.api.initso instead of defaulting toGET, it can default toPOSTPOST request
bodyis now verified in testsAlso fixes code so the example in the README works